John Moir was born in a French fortress at Verdun, the son of a naval surgeon. His parents were taken prisoner during the Napoleonic Wars and returned to Edinburgh in 1814, where his father established a medical practice with a special interest in obstetrics. John Moir graduated MD in 1827, specialised in midwifery and served on the staff of the maternity hospital, teaching students and nurses.
